Would you mind adding a bit more information about the fixes?

EDIT: I think the issue description speaks for itself, but the code might not.

Okay, so this fixes the crash problem and likely the issue with enemy heroes always showing on the radar.

So one thing i did notice from this is that Observers don't get hero icons showing on the radar.
The hero icons showing when i was playing back GR1 made me notice them more.

I wonder if there is some logic broken elsewhere that is stopping "revealed" heroes from showing for players and observers.

The condition for showing hero icons is object->isLocallyControlled().

The condition for showing hero icons is object->isLocallyControlled().

Yeah i just noticed that, so hero icons were only ever meant to show up for your own heroes and not all revealed heroes.

It was actually quite nice to spot all heroes when as an observer. Could be a nice feature to add later on.

Would you mind adding a bit more information about the fixes?

Done.

The condition for showing hero icons is object->isLocallyControlled().

Just doing the following lets it work for observers

if( obj->isLocallyControlled() || ThePlayerList->getLocalPlayer()->isPlayerObserver() )

It is quite neat being able to see where heroes are during a replay.

Yeah it's nice.

Yeah it's nice.

It's also what caused the crash when the hero was in the tunnel system in the replay. lol
Fish hero tunnel radar crash.zip

Replicated to Generals without conflicts.